Delete a connector

[Maggie]

Hi
I am trying to delete a connector from within my addin -

Code: [Select]

                   short index = 1;
                    foreach (EA.Connector conn in clientElement.Connectors)
                    {
                        //EA.Element clientElement = Repository.GetElementByID(connector.ClientID);
                        if (conn.Type == "Generalization" &&
                            clientElement.Stereotype == "abc" &&
                            conn.SupplierID == QObjectElement.ElementID)
                        {
                            clientElement.Connectors.Delete(index);
                            conn.Update();
                            clientElement.Refresh();
                            clientElement.Update();
                            supplierElement.Refresh();
                            supplierElement.Update();
                            break;
                        }
                        index++;

When I debug the addin the code to delete the connector is executed but the connector is not deleted from the model

I would be grateful if someone could tell me what I am doing wrong

Thanks

Maggie

[qwerty]

I'm not sure whether the collector iterator has the same order as your index. So I'd prefer to use GetAt to be sure that index and element to be deleted match.


Further you don't need the refresh and update methods. You should only call Connectors.Refresh AFTER the whole loop.

q.

P.S. I just recognized that I did not really explain Delete in my Scripting book. I shall add that...

[Geert Bellekens]

Maggie,

You are doing some weird stuff here.
* You are using a foreach loop, but then still want to use a counter... Why don't you simply use a for loop?

Code: [Select]

for (int i = 0; i< clientElement.Connectors.Count; i++)* When you are deleting from a collection you are looping then you should always start at the end. So the above loop should become

Code: [Select]

for (int i = clientElement.Connectors.Count -1; i >=0;i--) * right after you delete the connector from the element you save it again by calling conn.Update(). You should remove that call
* you don't need any of the update() and refresh() calls as qwerty already indicated.

Geert