Update is not a function

[Wojtas]

Hi,

I'm writing script that synchronize TVs between elements. When I try to Update TaggedValues collection after AddNew this error is thrown.
By the way, all scripts that operate on collection stop working. I don't remember is this related to last EA upgrade (can't recall when I upgrade EA), but I guess that it is connected.
Any ideas?

Kind regards,
Wojtek

[Geert Bellekens]

Post some of your code and indicate where it throws an error.

Geert

[Wojtas]

Code: [Select]

var theElement as EA.Element;
theElement = Repository.GetTreeSelectedObject();
var tvs as EA.Collection;
tvs = theElement.TaggedValues;
var klasa = Session.Input("Enter class of TV, eg.:\"System\"");
var regExp = new RegExp("^"+klasa);
var pt = Repository.PropertyTypes;
var ptc = pt.Count;
for(var i=0;i<ptc;i++)
{
      var TV = pt.GetAt(i);
      if(tvs.GetLastError())
            Session.Output("Global Error:"+tvs.GetLastError());
      if(TV.Tag.search(regExp)>=0 && !tvs.GetByName(TV.Tag))
      {
            Session.Output(TV.Tag);
            var tvsr = tvs.AddNew(TV.Tag,"");
            var updt = tvs.Update();
      }
}
var updt = tvs.Update(); generate problem.

Kind regards,
Wojtek

[qwerty]

You can not update the collection. You can call update only on newly generated elements/connectors/... Maybe you mean refresh(), but that's superfluous in most cases.

q.

[Geert Bellekens]

Why would you try to call Update() on an EA.Collection?
I don't think this has ever existed.
You call Update() on the individual objects, not on collections.

The only thing you sometimes need on a collection is Refresh(), but most often you don't even need that.

Geert

[Geert Bellekens]

You can not update the collection. You can call update only on newly generated elements/connectors/... Maybe you mean refresh(), but that's superfluous in most cases.

q.

Good to see we are on the same page on this  

Geert

[Wojtas]

Hi,

can't agree with you. For example collection EmbeddedElements can be extended by new elements. Used last week and this is existing collection as well. Why Tagged Value collection is ineditable (was accessible - 100% sure - I was adding TVs (30 newly defined) to ~80 component elements) and Embedded Elements collection is editable?
@Geert: AddNew and Update functions are defined on EA site:
http://www.sparxsystems.com/enterprise_architect_user_guide/12/automation_and_scripting/collection.html
Calling of Update is advised in AddNew function description.
var tvs as EA.Collection;
tvs = theElement.TaggedValues; - declares variable before use, I wrote this "hoping" that help, but didn't  
var tvs = theElement.TaggedValue; got back to this version, only thing that changed is that "Ctrl+Space" stop working - EA can't determine type of variable.
Continue digging :S

Kind regards,
Wojtek

[qwerty]

Well, two statements from experienced EA users against one from a rookie. That sounds like a good base for discussions.

q.

[Wojtas]

SOLVED  

Update function should be invoked on result element, not collection
Walked by old working script and found this difference.
Working code:

Code: [Select]

var theElement as EA.Element;
theElement = Repository.GetTreeSelectedObject();
var tvs as EA.Collection;
tvs = theElement.TaggedValues;
Session.Output(theElement.Name+" "+theElement.Stereotype+" "+theElement.ElementGUID);
var klasa = Session.Input("Podaj klas[ch281] TV, np.:\"System\"");
var regExp = new RegExp("^"+klasa);
var pt = Repository.PropertyTypes;
var ptc = pt.Count;
for(var i=0;i<ptc;i++)
{
      var TV = pt.GetAt(i);
      if(tvs.GetLastError())
            Session.Output("Global Error:"+tvs.GetLastError());
      if(TV.Tag.search(regExp)>=0 && !tvs.GetByName(TV.Tag))
      {
            Session.Output(TV.Tag);
            var tvsr = tvs.AddNew(TV.Tag,"");
            tvsr.Update();
      }
}            
break;
I have to change way I'm naming variables - tvs (for TaggedValueS) and tvsr (for TaggedValueSResult) are too easy to misstype.
Also on site with collection reference is stated:

Call Update on the item to save it to the database

Also note that you must call Update() on the returned object to complete the AddNew. If Update() is not called the object is left in an indeterminate state.

Have a nice day,
Wojtek

[Echo]

Hi,

Anyone has idea how to delete these "indeterminate" Status objects?

Same mistake I did, did not call Update function after AddNew. Then I can see this object I created in "Find in Project" view, but I cannot locate it in the ProjectBrowser. I tried to delete it directly in the "Find in Project" view, but failed with warning "Cannot delete this item from the Report View".

I created a ghost 

Frustrated,
Echo

[Geert Bellekens]

Running the project integrity check should resolve these type of issues.

Geert