Adding package on diagram with scriptlet (diagramObject is undefined)

[Hurra]

Hello!

I wanted to try out a scriptlet and want to add all childPackges in a diagram.

The setup:

Package contains childPackages and a diagram.
The scriptlet should add all the childPackages on the diagram.

The scriptlet:

Code: [Select]

function addPackagestoDiagram()
{
Repository.ClearOutput("Script");
Repository.EnsureOutputVisible("Script");

var currentDiagram as EA.Diagram;
var diagramPackage as EA.Package;
var childPackages as EA.Collection;
var diagramObjects as EA.Collection;
var diagramObject as EA.DiagramObject;
var currentPackage as EA.Package;

currentDiagram = Repository.GetCurrentDiagram();
diagramPackage = Repository.GetPackageByID(currentDiagram.PackageID);
childPackages = diagramPackage.Packages;
diagramObjects = currentDiagram.DiagramObjects;

for (i = 0; i < childPackages.Count; i++)
{
currentPackage = childPackages.GetAt(i);
diagramObject = diagramObjects.AddNew("","");
diagramObject.ElementID = currentPackage.Element.ElementID;
diagramObjects.Update();
diagramObject.Update();
}

currentDiagram.Update();
 

}
addPackagestoDiagram();

This line:

Code: [Select]

diagramObject.ElementID = currentPackage.Element.ElementID;

yields diagramObject is undefinied.

I've been looking at:
https://sparxsystems.com/forums/smf/index.php?topic=39128.0
and that is how it's done.

I've also tried changing

Code: [Select]

diagramObject.ElementID = currentPackage.Element.ElementID;
to

Code: [Select]

diagramObject.ElementID(currentPackage.Element.ElementID);
as in the linked thread.

But the problem occurs either way, giving diagramObject is undefinied.

What am I missing? 🤔

Thanks!

[Geert Bellekens]

it looks like the previous call to create a new DiagramObject failed (and returned NULL)

Code: [Select]

diagramObject = diagramObjects.AddNew("","");
Check the diagramObject variable for NULL before continuing.

Geert

[Hurra]

it looks like the previous call to create a new DiagramObject failed (and returned NULL)

Code: [Select]

diagramObject = diagramObjects.AddNew("","");
Check the diagramObject variable for NULL before continuing.

Geert

This

Code: [Select]

if (diagramObject == null)
{
    Session.Output("Geert were right as usual!");
}
indeed confirm this.

But how do I create the diagramObject then?

[Geert Bellekens]

like that, but there is something going wrong.

You can play a bit with the parameters (supply an name, and a position string) or try to see what diagramObjects.GetLastError() returns

Geert

[Hurra]

like that, but there is something going wrong.

You can play a bit with the parameters (supply an name, and a position string) or try to see what diagramObjects.GetLastError() returns

Geert

Yeah, I tried

Code: [Select]

diagramObject = diagramObjects.AddNew(currentPackage.Name, currentPackage.ObjectType);
based on https://sparxsystems.com/enterprise_architect_user_guide/16.0/add-ins___scripting/collection.html
-> AddNew(string Name, string Type)

But the diagramObjects.GetLastError() returns:

Code: [Select]

Script security: No create permission
Huh?

It's a local QEAX-file, I haven't touched security, it's not even enabled.

[Geert Bellekens]

Code: [Select]

diagramObject = diagramObjects.AddNew(currentPackage.Name, currentPackage.ObjectType);


Yeah, those are not the correct parameters for DiagramObjects

Try something like this:

Code: [Select]

diagramObjects.AddNew("l=10;r=100;t=10;b=200;", "")
And make sure to test your script as a regular script, before testing it as a scriptlet.

Geert

[Hurra]

...
Geert

I guess the permission warning is the major issue.

Code: [Select]

diagramObjects.AddNew("l=10;r=100;t=10;b=200;", "")This still results:
diagramObjects.GetLastError() = "Script security: No Create permission"

This is also the case when I run it as a regular script on the diagram.

[Geert Bellekens]

Must be something special with the diagram I guess. Have you tried with a new diagram?

I just tried this little (VB)script in v16.1 on a qea model, and it works just fine

Code: [Select]

sub main
dim diagram as EA.Diagram
dim package as EA.Package
set package = Repository.GetPackageByGuid("{A5CBF53F-2033-4c9a-B505-3341E5595393}")
set diagram = Repository.GetDiagramByGuid("{9585B09C-28C5-485b-AF25-79F1D70EAA18}")
dim diagramObjects as EA.Collection
dim diagramObject as EA.DiagramObject

set diagramObjects = diagram.DiagramObjects
set diagramObject = diagramObjects.AddNew("l=10;r=100;t=10;b=200;", "")
diagramObject.ElementID = package.Element.ElementID
diagramObject.Update
end sub

main
Geert

[qwerty]

diagramObjects.GetLastError() = "Script security: No Create permission"

Never seen that. And I'm not using the "security" often. So sounds there is a new granularity. Are you running that as admin?

q.

[Takeshi K]

Hello all,

As the help says, scriptlets cannot update something.

https://sparxsystems.com/enterprise_architect_user_guide/16.0/modeling_fundamentals/scriptlets.html

Code in Scriptlets cannot alter or update elements in the model database.

HTH,

[qwerty]

I would bet that Repository.Execute works in those "scriptlets". Just a guess, but that would be sparxian...

q.

[MichPaule]

As the help says, scriptlets cannot update something.

https://sparxsystems.com/enterprise_architect_user_guide/16.0/modeling_fundamentals/scriptlets.html

Code in Scriptlets cannot alter or update elements in the model database.

This seems not to be entirely true.
I'm able to alter stereotyped tagged value contents using scriptlets and the changes are immediately reflected in the model database (checked with DB Browser for SQLite).
Maybe the sentence is to be read verbatim ==> elements cannot be altered but their tagged values can...
If I'd only have more time I gladly would dig into this topic.
BR

Michael