Hierararchical Manage Locks for the love of...

[Uffe]

Brrrring!

- EA Support, Uffe.
- Yes, hello, so-and-so is off sick today. Could you unlock such-and-such a package?
- I can release all so-and-so's locks, is that OK?
- No, just package such-and-such please.
- OK, give me a couple of hours.

Could we please get either a tree view in the Manage Locks dialog, or a button Unlock Recursive, or a pop-up "Do you wish to unlock child elements as well?"

I mean OK, fine, I'm a consultant, I get paid by the hour. But I'd rather be developing custom profiles or a cool Add-In than unravelling a flattened-out package hierarchy to unlock stuff selectively.
Hell, I'd rather be battling with the RTF template editor...!

[Stefan Bolleininger]

Hi,

it would be something like that:

Code: [Select]

               //lockiteration from lockbreaker and exit
        public static bool lockiteration(EA.Package lockpackage, EA.Repository _Repo)
        {
            string lockbreaker = null;
            string lockbreaker_E = null;
            string lockbreaker_E_I = null;
            string lockbreaker_E_D = null;
            string lockbreaker_D = null;
            foreach (EA.Element element in lockpackage.Elements)
            {
                try
                {
                    lockbreaker_E = element.ElementGUID;
                    _Repo.Execute("DELETE FROM t_seclocks WHERE EntityID='" + lockbreaker_E + "'");
                }
                catch
                {
                    MessageBox.Show("Element Lock could not be released", "Failure", MessageBoxButtons.OK);
                    return false;
                }
            }

            foreach (EA.Element element in lockpackage.Element.Elements)
            {
                try
                {
                    lockbreaker_E_I = element.ElementGUID;
                    _Repo.Execute("DELETE FROM t_seclocks WHERE EntityID='" + lockbreaker_E_I + "'");
                }
                catch
                {
                    MessageBox.Show("Element Lock could not be released", "Failure", MessageBoxButtons.OK);
                    return false;
                }
            }
            foreach (EA.Diagram diagram in lockpackage.Element.Diagrams)
            {
                try
                {
                    lockbreaker_E_D = diagram.DiagramGUID;
                    _Repo.Execute("DELETE FROM t_seclocks WHERE EntityID='" + lockbreaker_E_D + "'");
                }
                catch
                {
                    MessageBox.Show("Diagram lock could not be released", "Failure", MessageBoxButtons.OK);
                    return false;
                }
            }

            foreach (EA.Diagram diagram in lockpackage.Diagrams)
            {
                try
                {
                    lockbreaker_D = diagram.DiagramGUID;
                    _Repo.Execute("DELETE FROM t_seclocks WHERE EntityID='" + lockbreaker_D + "'");
                }
                catch
                {
                    MessageBox.Show("Diagram lock could not be released", "Failure", MessageBoxButtons.OK);
                    return false;
                }
            }

            foreach (EA.Package package in lockpackage.Packages)
            {
                lockpackage = package;
                lockbreaker = lockpackage.PackageGUID;
                _Repo.Execute("DELETE FROM t_seclocks WHERE EntityID='" + lockbreaker + "'");
                if (!lockiteration(lockpackage, _Repo))
                    return false;
            }
            return true;
        }
not complete but working for the elements

[skiwi]

damn fine idea, must be pretty bad if you prefer using the RTF editor though

[Geert Bellekens]

In one of my addins I actually implemented a "steal lock" function to avoid this type of issues.
Now my users can steal any lock they need with a push of a button.
I also implemented what I call "smart locking". When locking a diagram it also locks the parent element/package and all elements that are local to the diagram (but not everything else that is shown on the diagram).
When locking an operation it also locks the implementation diagram etc...

I now never have to unlock anything for anyone anymore.

Geert

PS. I also never battle RTF generator. I tried once, and then decided Id'd rather write my own document generator; which I did.

[Stefan Bolleininger]

That's what I did with the lockieration (code above)

Any User can force the whole package to be unlocked by the pressing of one button. To make it easier and more reproduceable

          

Code: [Select]

EA.IDualMailInterface Mailer = Repo.GetMailInterface();
          EA.Package lockpackage = Repo.GetTreeSelectedPackage();
          string lockpackagename = lockpackage.Name;
          string username = Repo.GetCurrentLoginUser();
          string subject = "Locked '" + lockpackagename + "' force-unlocked by " + username + "";
          string usernameGUID = ENARTalis_main.delxml(Repo.SQLQuery("Select UserID from t_secuser WHERE UserLogin ='" + username + "'"));
          string RecipientGUID = ENARTalis_main.delxml(Repo.SQLQuery("Select UserID from t_secuser WHERE UserLogin ='admin'"));
          string Message = "Lock removed by deleting lockinformation";
          try
          {
              Mailer.SendMailMessage(RecipientGUID, subject, EA.MessageFlag.mfPurple, Message);
              Mailer.SendMailMessage(usernameGUID, subject, EA.MessageFlag.mfPurple, Message);
          }
          catch (Exception)
          {
              MessageBox.Show("Mail has not been sent!", "OK", MessageBoxButtons.OK, MessageBoxIcon.Information);
              return;
          }
          bool success = true;
          string lockbreaker = null;
          lockbreaker = lockpackage.PackageGUID;
          Repo.Execute("DELETE FROM t_seclocks WHERE EntityID='" + lockbreaker + "'");
          success = ea.ENARTalis_main.lockiteration(lockpackage, Repo);

The MailInterface was just for playing purpose (And a bit of statistic, how often it is really used)  

Additional at the Event EA_FileClose():

Code: [Select]

                   
string usernameGUID = Repo.GetCurrentLoginUser(true);
string lockeditemsfile = Repo.SQLQuery("Select EntityID from t_seclocks where UserID = '" + usernameGUID + "'");
string lockeditems = xmlnode(lockeditemsfile, "</EntityID>");
string[] split = lockeditems.Split(new Char[] { ',' });
foreach (string s in split)
                    {
                        Repo.Execute("DELETE FROM t_seclocks WHERE EntityID='" + s + "'");
                    }

Regards

Stefan

[Uffe]

Yes, well and good, but my point is that this function should be in the admin GUI. It would surely be a very simple one for Sparx to implement, since there already are recursive lock/unlock functions.

Leaving aside the fact that allowing all users the option of stealing each others' locks defeats the purpose of having locks in the first place, there's way too much hacking required in order to effectively administer an EA project.

[Geert Bellekens]

Uffe,

I think we all support your request, just sharing the workarounds we developed over time to make up for the lack of usability in EA.

Geert

[skiwi]

Time to revive these suggestions?